Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-10] Fix Zone API 리팩토링 및 Fix Zone Comment API 개발 #60

Merged
merged 4 commits into from
Jul 26, 2024
Merged

[DEV-10] Fix Zone API 리팩토링 및 Fix Zone Comment API 개발 #60

merged 4 commits into from
Jul 26, 2024

Conversation

wonjunYou
Copy link
Collaborator

@wonjunYou wonjunYou commented Jul 25, 2024 •
edited
Loading

🚀 작업 내용

  • 기존 Fix Zone API를 추가 및 리팩토링하였습니다.

    • Fix Zone 수정 및 삭제
    • Fix Zone 등록
    • 클럽별 본인이 작성한 Fix Zone 조회 API
    • Fix Zone 전체 조회 및 상세 조회 API
    • Fix Zone 처리 완료 상태 변경 API

  • Fix Zone Comment 관련 API를 추가하였습니다.

    • Fix Zone 댓글 등록 API
    • Fix Zone 댓글 수정 및 삭제 API

  • Swagger 명세를 완료하였습니다.

🤔 고민했던 내용

  • 서비스 layer가 하나라서, 응답 DTO를 생성해주는 로직과 실제 타 비즈니스 로직에 필요한 엔티티 객체를 반환하는 로직이 공존하여 유지보수와 네이밍이 어려운 것 같습니다. 추후 개선이 필요할 것 같아요
  • Swagger에서 multipart/form-data 형식으로 이미지 및 파일을 업로드 하다 보니 converter를 비롯하여 여러 부가 명세가 많이 추가되네요! 해당 부분도 추후 pre-signed url로 리팩토링 했으면 좋겠습니다!

전달사항

PR이 살짝 커졌네요... ㅎㅎ

@wonjunYou wonjunYou added ✨기능 기능 개발 및 구현 🎯리팩토링 리팩토링 및 고도화 이슈 labels Jul 25, 2024
@wonjunYou wonjunYou requested a review from 5uhwann July 25, 2024 02:00
@wonjunYou wonjunYou self-assigned this Jul 25, 2024
@notion-workspace Notion Workspace
Copy link

fix_zone 기능

@wonjunYou wonjunYou closed this Jul 25, 2024
@wonjunYou wonjunYou reopened this Jul 25, 2024
@wonjunYou
Copy link
Collaborator Author

스크린샷 2024-07-26 오전 1 53 22 앞선 PR 충돌 해결도 완료했습니다~

5uhwann
5uhwann reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@5uhwann 5uhwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

src/main/java/ddingdong/ddingdongBE/domain/fixzone/controller/api/AdminFixZoneApi.java Outdated Show resolved Hide resolved
...a/ddingdong/ddingdongBE/domain/fixzone/controller/dto/response/GetDetailFixZoneResponse.java Outdated Show resolved Hide resolved
@wonjunYou wonjunYou requested a review from 5uhwann July 26, 2024 12:08
5uhwann
5uhwann approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@5uhwann 5uhwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@wonjunYou wonjunYou merged commit 4c44f5b into develop Jul 26, 2024
@wonjunYou wonjunYou deleted the feat/DEV-10 branch July 26, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5uhwann 5uhwann 5uhwann approved these changes

Assignees

@wonjunYou wonjunYou

Labels
✨기능 기능 개발 및 구현 🎯리팩토링 리팩토링 및 고도화 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wonjunYou @5uhwann