Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9] 동아리 평가 점수 조회 로직 수정 #63

Merged
merged 15 commits into from
Jul 27, 2024
Merged

Conversation

5uhwann
Copy link
Collaborator

@5uhwann 5uhwann commented Jul 26, 2024

🚀 작업 내용

동아리 평가 점수 조회 로직 수정

as if

  • 가장 최신 ScoreHistory의 remainingScore로 현재 동아리 점수로 평가
[
    {
        "scoreCategory": "점수 등록 취소",
        "reason": "오기입",
        "amount": -2.0,
        "remainingScore": -2.0,
        "createdAt": "2023-09-03T22:06:14.076245"
    }
]

to do

  • 동아리 점수 내역 조회 응답에 실제 동아리 점수를 응답
{
    "totalScore" : 50,
    "scoreHistories" : [
        {
            "scoreCategory": "점수 등록 취소",
            "reason": "오기입",
            "amount": -2.0,
            "createdAt": "2023-09-03T22:06:14.076245"
        }
        // 여러 개
    ]
}

🤔 고민했던 내용

💬 리뷰 중점사항

@5uhwann 5uhwann added the 🎯리팩토링 리팩토링 및 고도화 이슈 label Jul 26, 2024
@5uhwann 5uhwann requested a review from wonjunYou July 26, 2024 13:33
@5uhwann 5uhwann self-assigned this Jul 26, 2024
Copy link

Copy link
Collaborator

@wonjunYou wonjunYou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료입니다~!!

@5uhwann 5uhwann merged commit 771826d into develop Jul 27, 2024
@5uhwann 5uhwann deleted the feature/DEV-9 branch July 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯리팩토링 리팩토링 및 고도화 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants