[8주차] 박수현 #23
Open
[8주차] 박수현 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
멤버 컨트롤러입니다.
멤버 서비스입니다.
멤버 레포지토리입니다.
Member 요청과 응답입니다.
Post컨트롤러입니다.
Post서비스입니다.
Post레포지토리입니다.
Post 요청과 응답입니다.
Suehyun666
requested review from
Hoya324,
KoSeonJe and
TaetaetaE01
as code owners
Hoya324
reviewed
Nov 21, 2024
Comment on lines
+21
to
+43
| private final CommentService commentService; | ||
| private final MemberService memberService; | ||
| private final PostService postService; | ||
| @PostMapping | ||
| @ResponseStatus(HttpStatus.CREATED) | ||
| public void addComment(@PathVariable String title, @RequestBody CreateCommentRequest createCommentRequest) { | ||
| Member member = memberService.findMemberById(createCommentRequest.getUserId()); | ||
| commentService.addComment(title, member.getId(), createCommentRequest.getContent());} | ||
| @GetMapping | ||
| public List<CommentResponse> getComments(@PathVariable String title) { | ||
| Post post = postService.findPostByTitle(title); | ||
| return commentService.getCommentsByPostId(post.getId()).stream() | ||
| .map(comment -> new CommentResponse(comment.getId(), comment.getContent(), comment.getMember().getId(), comment.getPost().getId())) | ||
| .collect(Collectors.toList()); | ||
| } | ||
| @PutMapping("/{commentId}") | ||
| public void updateComment(@PathVariable Long commentId, @RequestBody String content) { | ||
| commentService.updateComment(commentId, content); | ||
| } | ||
| @DeleteMapping("/{commentId}") | ||
| public void deleteComment(@PathVariable Long commentId) { | ||
| commentService.deleteComment(commentId); | ||
| } |
There was a problem hiding this comment.
각 메서드, 필드 부분마다 개행을 추가해서 가독성을 높여주세료!
Comment on lines
+30
to
+34
| public List<CommentResponse> getComments(@PathVariable String title) { | ||
| Post post = postService.findPostByTitle(title); | ||
| return commentService.getCommentsByPostId(post.getId()).stream() | ||
| .map(comment -> new CommentResponse(comment.getId(), comment.getContent(), comment.getMember().getId(), comment.getPost().getId())) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
commentService에서 하지 않고 controller에서 post를 찾아 보내주는 이유가 있을까요?
만약 post, user, event 등등 찾아야하는 엔티티가 증가한다면 어떻게 리팩토링할까요??
Comment on lines
+5
to
+8
| @Getter | ||
| public class UpdateCommentRequest { | ||
|
|
||
| } |
| this.userId = userId; | ||
| this.postId = postId; | ||
| } | ||
| } |
Comment on lines
+25
to
+29
| Comment comment = Comment.builder() | ||
| .content(content) | ||
| .member(member) | ||
| .post(post) | ||
| .build(); |
There was a problem hiding this comment.
정적 팩토리 메서드에 대해 생각해보시면 좋을거 같습니다!
|
|
||
| @Builder | ||
| private Member(String name, String email, String password) { | ||
| this.id = ++idCounter; |
There was a problem hiding this comment.
해당 도메인과 entity가 함께 존재하는 이유가 있나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가 Q & A
🤔 잘 모르겠거나, 더 궁금한 내용이 있었나요?
집중적으로 리뷰 받고싶은 것이 있나요?