-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the .hdf5/.npz model format #99
Comments
Seems fine to me. Some thoughts:
|
Here's a prototype (seems to work, didn't check if the produced model is correct): Code: https://gist.github.com/fdlm/b4be1190af0bfc9f2e7a |
Regarding your points:
Let's do it this way. |
As outlined in #102, I think the right way of doing this is to add the loading functionality to the The Anything I have missed? |
The whole thing is basically a reimplementation of |
Refactor the neural network stuff into ml.nn. Additionally, the models are simple pickles now; fixes #99.
Right now the model format is suited only for RNNs (for historical reasons), but we should extend/rework it in a way it is able to do everything. I hereby propose the following:
Questions:
Example:
The text was updated successfully, but these errors were encountered: