Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt spl, rms & energy to work with Signal and FramedSignal #208

Merged
merged 2 commits into from
Feb 25, 2017

Conversation

superbock
Copy link
Collaborator

No description provided.

@superbock superbock changed the title adapt spl, rms & energy to also work on frames; fixes #114 adapt spl, rms & energy to work with Signal and FramedSignal Feb 21, 2017
@superbock superbock force-pushed the framed_spl_rms_energy branch 2 times, most recently from 3c3727b to da388b5 Compare February 24, 2017 16:37
@superbock superbock requested a review from fdlm February 24, 2017 16:38
@superbock
Copy link
Collaborator Author

@fdlm, does this fix your original issue (#114)?

Copy link
Contributor

@fdlm fdlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes. Just needs some docstring adaptations...

"""
Computes the root mean square of the signal. This can be used as a
measurement of power.
Compute the energy of the signal.

Parameters
----------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt Parameters docstring (signal can also be a FramedSignal)


Parameters
----------
signal : numpy array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt Parameters docstring (signal can also be a FramedSignal)



def sound_pressure_level(signal, p_ref=None):
"""
Computes the sound pressure level of a signal.
Compute the sound pressure level of a signal.

Parameters
----------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt Parameters docstring (signal can also be a FramedSignal)

@superbock superbock merged commit a4feaf6 into master Feb 25, 2017
@superbock superbock deleted the framed_spl_rms_energy branch February 25, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants