fixes error loading unicode filenames #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokadillo
force-pushed
the
fixes/unicode_filenames
branch
from
3e3f2e8
to
4111bdc
Compare
superbock
reviewed
Oct 25, 2016
| @@ -723,6 +724,9 @@ def test_types(self): | |||
| self.assertIsInstance(signal, np.ndarray) | |||
| self.assertTrue(signal.dtype == np.int16) | |||
| self.assertTrue(type(sample_rate) == int) | |||
| if sys.version_info[0] == 2: | |||
| # test unicode string type (Python 2 only) | |||
| signal, sample_rate = load_audio_file(unicode(sample_file)) | |||
There was a problem hiding this comment.
Is there a reason to check this only for Python 2? Shouldn't this be checked for Python 3, too?
There was a problem hiding this comment.
Python 3 has no unicode type, therefore I cannot execute unicode(sample_file).
There was a problem hiding this comment.
In Python 3, all strings are unicode by default.
flokadillo
force-pushed
the
fixes/unicode_filenames
branch
2 times, most recently
from
b2cf5fb
to
d8092e2
Compare
superbock
force-pushed
the
fixes/unicode_filenames
branch
from
d8092e2
to
abadca3
Compare
superbock
force-pushed
the
fixes/unicode_filenames
branch
from
abadca3
to
93b4281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #220. Closing the file is now in a try block.