Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated new Key Classification Model (ISMIR 2018) #381

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Integrated new Key Classification Model (ISMIR 2018) #381

merged 2 commits into from
Nov 5, 2018

Conversation

fdlm
Copy link
Contributor

@fdlm fdlm commented Oct 1, 2018 •
edited
Loading

  • Add reference to README
  • Changelog
  • Fix Travis problem

@superbock superbock added this to the v0.16 milestone Oct 18, 2018
@superbock
Copy link
Collaborator

It seems that the Travis failure is the same as mentioned in #374. I was not able to track it down so I disabled doctests during CI runs with Python 3.6+ for now. You could rebase this PR when #374 is merged. Please add another PR for the models.

superbock pushed a commit that referenced this pull request Oct 18, 2018
bumb required numpy version; add mido
cc0430a 
fixes #321; closes #331; fixes #381
@fdlm fdlm force-pushed the key2018 branch 2 times, most recently from 71f510c to 705952a Compare November 2, 2018 09:20
@fdlm fdlm requested a review from superbock November 2, 2018 13:53
@fdlm fdlm changed the title [WIP] Integrated new Key Classification Model (ISMIR 2018) Integrated new Key Classification Model (ISMIR 2018) Nov 2, 2018
superbock
superbock approved these changes Nov 2, 2018
View reviewed changes
Copy link
Collaborator

@superbock superbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the missing author information.

madmom/features/key.py Outdated
"End-to-End Musical Key Estimation Using a Convolutional Neural
Network", In Proceedings of the 25th European Signal Processing
Conference (EUSIPCO), Kos, Greece, 2017.
.. [1] "Genre-Agnostic Key Classification with Convolutional Neural
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author information is missing.

@fdlm fdlm merged commit 870189b into master Nov 5, 2018
@fdlm fdlm deleted the key2018 branch November 5, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superbock superbock superbock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16
Development

Successfully merging this pull request may close these issues.
2 participants
@fdlm @superbock