Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kern fixes (parsing editorials) #370

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Kern fixes (parsing editorials) #370

merged 4 commits into from
Oct 2, 2024

Conversation

manoskary
Copy link
Member

Support for parsing Kern Files with Editorial Comments and Alternative Passages.

This PR addresses the parsing of Kern scores that include editorial comments such as alternative passages.
Such passages that could previously cause parsing errors can now be ignored and only the original passage or part is kept.

Specific Comments on Code

  • Two lines are commented out in load_kern which were inverting the part order, this has to be avoided in case the far right part contains only editorials. Instead, the part order is inversed when the partlist is passed to the score. Since this functionality changes, it should be monitored for potential errors.
  • A Kern Object class is introduced for elements that do not correspond to partitura objects but describe the Kern parsing process within the format (e.g. editorials, or voice splitting/merging)

@manoskary manoskary added bug Something isn't working enhancement New feature or request labels Aug 28, 2024
@manoskary manoskary requested a review from fosfrancesco August 28, 2024 13:22
@manoskary manoskary self-assigned this Aug 28, 2024
@manoskary manoskary linked an issue Aug 28, 2024 that may be closed by this pull request
partitura/io/importkern.py Outdated Show resolved Hide resolved
partitura/io/importkern.py Show resolved Hide resolved
@manoskary manoskary merged commit 1ca009c into develop Oct 2, 2024
3 checks passed
@sildater sildater mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Humdrum editorials/ part splits cause Nans in duration features
2 participants