Clef feature #382
Merged
Clef feature #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoskary
reviewed
Oct 10, 2024
manoskary
requested changes
Oct 11, 2024
merging by staff required, merging by voice discard clefs.
manoskary
requested changes
Oct 22, 2024
There was a problem hiding this comment.
This PR adresses a Clef feature within note features, it also corrects a number of vulnerabilities at other note_features dependent on the notes_tied instead of the note_array, To ensure correct order a remapping was proposed using a dictionary with note ids, however there is a small comment regarding the uniqueness of note ids.
manoskary
approved these changes
Oct 25, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a simple note feature encoding the currently active clef by sign, line, and octave change.