fix: Minor fixes #217
fix: Minor fixes #217
Conversation
| # Description of this definition to be used in messages to the user. | ||
| # The returned text should fit into messages of the following form: "expected | ||
| # a function, but got {description of this definition} instead". | ||
| description: str |
There was a problem hiding this comment.
N.B. in all of our subclasses of Definition, description is defined as a field
There was a problem hiding this comment.
Does pyright complain about this? In the future we might have definitions where the description depends on the instance (for example if we unify struct and enum definitions into one class), so I would rather leave it more general
There was a problem hiding this comment.
To be clear: the complaint is that the parent has property called description, and the subclasses are shadowing that name with a str field. I think to inherit properties the subclasses also need to look like:
class A(Definition):
@property
def definition() -> str:
...
but I could easily be wrong
There was a problem hiding this comment.
I see. The thing is that fields on frozen dataclasses are observably equivalent to get-only properties, so it's the same interface. But it looks like pyright doesn't recognise this...
It's confusing that we use the same pattern for TypeBase.linear but it's not complaining there?
I tried adding pyright to my environment instead of mypy, and it highlighted these issues!