feat: Lower arrays #82
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 82.97% 82.92% -0.05%
==========================================
Files 18 18
Lines 2390 2431 +41
Branches 2390 2431 +41
==========================================
+ Hits 1983 2016 +33
- Misses 253 255 +2
- Partials 154 160 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -174,6 +209,12 @@ impl<'c, H: HugrView, PCG: PreludeCodegen> CodegenExtension<'c, H> | |||
| let signal_ty = ctx.i32_type().into(); | |||
| let message_ty = ctx.i8_type().ptr_type(AddressSpace::default()).into(); | |||
| Ok(ctx.struct_type(&[signal_ty, message_ty], false).into()) | |||
| } else if hugr_type.name() == "array" { | |||
There was a problem hiding this comment.
Prelude unfortunately doesn't export a name constant for the array type
| &self, | ||
| _session: &TypingSession<'c, H>, | ||
| elem_ty: BasicTypeEnum<'c>, | ||
| size: u64, |
There was a problem hiding this comment.
Seems like this arg should be a u32
There was a problem hiding this comment.
Hugr's TypeArg::BoundedNat which is used to specify array lengths is u64. Other implementors of PreludeCodegen might have different ways of interpreting this number, so I'd prefer to leave the conversion to implementors of the trait
## 🤖 New release * `hugr-llvm`: 0.2.1 -> 0.3.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.0](v0.2.1...v0.3.0) - 2024-08-27 ### New Features - [**breaking**] Lower string, print, and panic ([#78](#78)) - Lower float operations ([#83](#83)) - Lower logic extension ([#81](#81)) - Lower arrays ([#82](#82)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Closes #24