Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: write output in py::cli #8

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: write output in py::cli #8

merged 1 commit into from
Jan 16, 2025

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Jan 16, 2025

Tested with pytest --basetemp _x && cat _x/test_guppy_planqc_qcurrent/out.ll

@doug-q doug-q requested a review from trvto January 16, 2025 11:10
trvto
trvto approved these changes Jan 16, 2025
View reviewed changes
Copy link

@trvto trvto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I checked by debugging into the python test and opening up the temporary file. It's being written into now 💥

@doug-q doug-q merged commit 05868ba into main Jan 16, 2025
1 check passed
@doug-q doug-q deleted the doug/fix-no-py-cli-out branch January 16, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trvto trvto trvto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doug-q @trvto