Allow changing extension_reqs in SiblingSubgraph::create_simple_replacement.
#1175
Assignees
Labels
bug
Something isn't working
Comments
aborgna-q
changed the title
extension_reqs in new replacement.extension_reqs in SimpleReplacement.
aborgna-q
changed the title
extension_reqs in SimpleReplacement.extension_reqs in SiblingSubgraph::create_simple_replacement.
This was referenced Jun 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 7, 2024
…nt (#1177) Fixes #1175 Signatures have three components: - The input type row - The output type row - The set of extensions used by the local operations Many interesting replacements in a graph changes the latter, but `SiblingSubgraph::create_simple_replacement` required the signatures to match exactly.
github-merge-queue bot
pushed a commit
to CQCL/tket2
that referenced
this issue
Jun 17, 2024
…ors (#390) - Stores the circuit name in the `FuncDefn` operations instead of a "name" metadata key. In the future we will decode tket1 circuits into funtion definitions instead of Dfg blocks, but that currently causes errors due to CQCL/hugr#1175. - `Circuit::circuit_signature` returns a `FunctionType` instead of a `PolyFuncType`, since we (currently) don't allow parametric signatures. - Improves the errors when constructing and manipulating circuits. This work is in the path to solving #385 and #389, but we will require some fixes in hugr (CQCL/hugr#1177) before fixing the support for non-Dfg rooted circuits.
github-merge-queue bot
pushed a commit
to CQCL/tket2
that referenced
this issue
Jun 17, 2024
Followup to #390. Fixes #389. Closes #385. ~~Blocked by CQCL/hugr#1175 Fixes support for non-`Dfg` circuits and circuits with a non-root parent: Adds a `Circuit::extract_dfg(&self)` function that extracts the circuit into a new hugr with a DFG operation at the root. In some cases, like in a CFG DataflowBlock node, this requires some changes to the definition to eliminate the output sum type. Here I only implemented it for the kind of blocks produced by guppy. We could replace the manual implementation once CQCL/hugr#818 gets implemented. With this we can now fix #389 by extracting the circuit before using it as a replacement in `SimpleReplacement::create_simple_replacement`. Replaces `DfgBuilder` with `FunctionBuilder` where possible, so we can use named circuits in the tests. (This failed before due to the bug in CircuitRewrite).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Replacing a node with another that requires more extensions should be possible, but currently it fails with a
InvalidReplacement::InvalidSignatureerror due to the mismatchedextension_reqs.The text was updated successfully, but these errors were encountered: