Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining bits of builder frontend for inference #1318

Closed
4 tasks
Tracked by #426
acl-cqc opened this issue Jul 16, 2024 · 0 comments · Fixed by #1386
Closed
4 tasks
Tracked by #426

Remaining bits of builder frontend for inference #1318

acl-cqc opened this issue Jul 16, 2024 · 0 comments · Fixed by #1386
Assignees
@acl-cqc

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Jul 16, 2024

  • cfg_builder (CFGBuilder::new takes a FunctionType so no need to update),
  • tail_loop_builder
  • ConditionalBuilder::new
  • TailLoopBuilder::new
@acl-cqc acl-cqc mentioned this issue Jul 16, 2024
Open
22 tasks
@acl-cqc acl-cqc changed the title Remaining bits of builder frontend for intference Remaining bits of builder frontend for inference Jul 16, 2024
@acl-cqc acl-cqc self-assigned this Jul 16, 2024
@acl-cqc acl-cqc mentioned this issue Jul 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2024
@acl-cqc
feat!: Update remaining builder methods to "infer by default" (#1386)
b75dd09 
closes #1318 and also deals with BlockBuilder not mentioned there.
I think this is now all of the nested-structures covered:
| | XBuilder::new | fn x |
|----|----|----|
|Conditional|**here**|in #1226|
|\->Case|takes `Signature`|inherits exts|
|TailLoop|**here**|**here**|
|DFG|takes `Signature`|takes `Signature` (`dfg_builder_endo` in #1219)|
|CFG|takes `Signature`|**here**|
|\->Block|**here**|in #1226|

(FuncDefn takes `Signature` and is *not supported by inference yet*
anyway)

BREAKING CHANGE: `cfg_builder`, `tail_loop_builder`,
`ConditionalBuilder::new`, `BlockBuilder::new` and
`TailLoopBuilder::new` no longer take an ExtensionSet parameter; either
remove the argument (to use extension inference) or use the `_exts`
variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acl-cqc acl-cqc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Update remaining builder methods to "infer by default" CQCL/hugr
1 participant
@acl-cqc