Rename extension_reqs to runtime_reqs
#1734
Assignees
Milestone
Comments
22 tasks
aborgna-q
changed the title
extension_reqs to runtime_reqs as this is a different measurement to static requirements (which extensions we need to have declarations of, i.e. type-checking info in the ExtensionRegistry)extension_reqs to runtime_reqs
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 3, 2024
When we do a serialization roundtrip on a hugr, its custom optypes are downgraded to `OpaqueOp`s and its `CustomType`s lose the weak link to their extension. This PR moves the pre-existing `OpaqueOp` resolution into a new `crate::extension::resolution` module and expands it to also update the custom type pointers. This can be run via the new `Hugr::resolve_extension_defs` method (currently called by `update_validate`). In addition, we accumulate the exact list of extensions required to define the hugr (this will be necessary for #1613). Note that this will probably be no longer necessary after we stabilize `hugr-model`, as we manually build the hugr when importing the model so the extensions should already be present at that point. In contrast to extension inference, this detects extensions needed to _define_ a hugr (vs runtime requirements). The inference one will be renamed as per #1734. A big chunk of this PR is fixing tests that used `finish_prelude_hugr` even though they required more extensions -.-' Look at the first commit for the actual changes. BREAKING CHANGE: Removed `resolve_opaque_op` and `resolve_extension_ops`. Use `Hugr::resolve_extension_defs` instead.
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 10, 2024
…1738) Closes #1613. Depends on #1739. Hugrs now keep an `Extensions` registry that is automatically computed when using the builder or deserializing from json (using the new `Hugr::load_json`). This set can contain unneeded extensions, but it should always be sufficient to validate the HUGR definition. Note that this is **not** runtime extensions (see #426, #1734). A big chunk of the diff is removing the extension registry when finishing building a hugr. The extension tracking is now done automatically while adding operations. drive-by: Remove unneeded `set_num_ports` call in `insert_hugr_internal`. BREAKING CHANGE: Removed `update_validate`. The hugr extensions should be resolved at load time, so we can use `validate` instead. BREAKING CHANGE: The builder `finish_hugr` function family no longer takes a registry as parameter, and the `_prelude` variants have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rename
extension_reqstoruntime_reqsas this is a different measurement to static requirements (which extensions we need to have declarations of, i.e. type-checking info in the ExtensionRegistry)The text was updated successfully, but these errors were encountered: