Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Update to portgraph 0.13 & petgraph 0.7 #1872

Closed
aborgna-q opened this issue Jan 17, 2025 · 0 comments · Fixed by #1878
Closed

chore!: Update to portgraph 0.13 & petgraph 0.7 #1872

aborgna-q opened this issue Jan 17, 2025 · 0 comments · Fixed by #1878
Assignees
Labels
rust Pull requests that update Rust code

Comments

@aborgna-q
Copy link
Collaborator

We moved to RpiTiT on portgraph and changed the signature of subgraphs, so this brings some migration pains.

@aborgna-q aborgna-q added the rust Pull requests that update Rust code label Jan 17, 2025
@aborgna-q aborgna-q self-assigned this Jan 17, 2025
@doug-q doug-q mentioned this issue Jan 20, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 20, 2025
The new portgraph release comes with some perf improvements.
We require this update for #1869.

Closes #1872.

I added a benchmark variation for subgraphs with few nodes as a
drive-by.
This got improved by the new portgraph (skipping a full graph
traversal), but the runtime is still mostly the `O(n)` full-graph
traversal required for the convexity checking when building the
subgraph.

BREAKING CHANGE: Bumped public dependency `portgraph` to breaking
version `0.13`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant