Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate resolve_extension_ops into validate / infer_and_validate #508

Closed
acl-cqc opened this issue Sep 8, 2023 · 1 comment
Closed

Integrate resolve_extension_ops into validate / infer_and_validate #508

acl-cqc opened this issue Sep 8, 2023 · 1 comment

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Sep 8, 2023 •
edited
Loading

Moreover, resolve_extension_ops was intended to use after loading the Hugr, but the checks in here that saved Signatures match the Signatures that would be computed, would make sense to do in validation. validate and infer_and_validate are also the main entry points for when you do have an ExtensionRegistry. In validate the Hugr is immutable but we could do this in infer_and_validate just prior to validation....
This was referenced Sep 8, 2023
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 12, 2023
@acl-cqc
[refactor] resolve_extension_ops: take an ExtensionRegistry (#520)
9ebbe75 
This turns out to be pretty trivial, as ExtensionRegistry looks exactly
the same as HashMap as far as this code is concerned. Most of the effort
here is in fixing up imports and doclinks.

This addresses the first (easy) part of #508 but the second remains as
an issue/question for discussion, not attempting to resolve that here.
@acl-cqc acl-cqc changed the title Update resolve_extension_ops w/ ExtensionRegistry; integrate into validation?? Integrate resolve_exetsion_ops into validate / infer_and_validate Sep 13, 2023
@acl-cqc acl-cqc changed the title Integrate resolve_exetsion_ops into validate / infer_and_validate Integrate resolve_extension_ops into validate / infer_and_validate Sep 13, 2023
@acl-cqc acl-cqc mentioned this issue Sep 27, 2023
Closed
acl-cqc added a commit that referenced this issue Sep 28, 2023
@acl-cqc
Rename {CachedType=>TypeApplyCache}Incorrect, drop comment about #508
375ef33
@acl-cqc
Copy link
Contributor Author

acl-cqc commented Mar 26, 2024

This was done in #603, renaming infer_and_validate to update_validate

@acl-cqc acl-cqc closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RFC: {infer=>intern}_and_validate calls resolve_extension_ops CQCL/hugr
1 participant
@acl-cqc