Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Separate Signature from FuncValueType by parametrizing Type(/Row)/etc. #1138

Merged
merged 123 commits into from
Jul 17, 2024

oops, fix doc

eb4152a
Select commit
Loading
Failed to load commit list.
Merged

refactor!: Separate Signature from FuncValueType by parametrizing Type(/Row)/etc. #1138

oops, fix doc
eb4152a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 17, 2024 in 0s

87.31% (-0.03%) compared to 6f8dac2

View this Pull Request on Codecov

87.31% (-0.03%) compared to 6f8dac2

Details

Codecov Report

Attention: Patch coverage is 86.62338% with 103 lines in your changes missing coverage. Please review.

Project coverage is 87.31%. Comparing base (6f8dac2) to head (eb4152a).

Files Patch % Lines
hugr-core/src/builder/dataflow.rs 57.14% 0 Missing and 12 partials ⚠️
hugr-passes/src/nest_cfgs.rs 0.00% 0 Missing and 12 partials ⚠️
hugr-core/src/types.rs 90.35% 11 Missing ⚠️
hugr-core/src/types/signature.rs 81.81% 9 Missing and 1 partial ⚠️
hugr-core/src/builder/cfg.rs 36.36% 0 Missing and 7 partials ⚠️
hugr-core/src/types/row_var.rs 83.33% 5 Missing and 1 partial ⚠️
hugr-core/src/extension/op_def.rs 88.09% 3 Missing and 2 partials ⚠️
hugr-core/src/hugr/validate/test.rs 91.22% 0 Missing and 5 partials ⚠️
hugr-core/src/types/check.rs 0.00% 3 Missing and 2 partials ⚠️
hugr-core/src/hugr/rewrite/inline_dfg.rs 0.00% 0 Missing and 4 partials ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   87.33%   87.31%   -0.03%     
==========================================
  Files         107      108       +1     
  Lines       19642    19784     +142     
  Branches    17378    17520     +142     
==========================================
+ Hits        17155    17275     +120     
- Misses       1705     1724      +19     
- Partials      782      785       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov