Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: is_ext utility for checking equality against extension ops #1499

Closed
wants to merge 1 commit into from

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 2, 2024

Open to bikeshedding on name of is_ext

left in an assert_eq that just uses cast directly as a comparison (this may not be worthwhile)

@ss2165 ss2165 requested a review from a team as a code owner September 2, 2024 15:58
@ss2165 ss2165 requested a review from doug-q September 2, 2024 15:58
@ss2165 ss2165 added this to the hugr-rs 0.12.1 / hugr-py 0.8.1 milestone Sep 2, 2024
@ss2165 ss2165 requested review from acl-cqc and removed request for doug-q September 2, 2024 15:58
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (a38e58c) to head (5e9d7e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         126      126           
  Lines       21633    21638    +5     
  Branches    18662    18667    +5     
=======================================
+ Hits        18884    18889    +5     
  Misses       1979     1979           
  Partials      770      770           
Flag Coverage Δ
python 92.72% <ø> (ø)
rust 86.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165
Copy link
Member Author

ss2165 commented Sep 3, 2024

Closing as I've convinced myself it's not useful.

@ss2165 ss2165 closed this Sep 3, 2024
@ss2165 ss2165 deleted the ss/is_ext branch September 3, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant