-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Special cased array, float and int constants in hugr-model export #1857
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
========================================
Coverage 86.55% 86.56%
========================================
Files 195 195
Lines 35584 35686 +102
Branches 32397 32499 +102
========================================
+ Hits 30800 30891 +91
+ Misses 3012 3010 -2
- Partials 1772 1785 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
7b7bc0d
to
b588731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
79a9137
to
39dafb9
Compare
This PR special cases the import/export of array, float and int constants so that they are represented as terms in
hugr-model
. This representation is a lot more efficient to handle than the encoding as JSON. In the future we should do this for all constants.