Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export RemoveDeadFuncsError #1883

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

aborgna-q
Copy link
Collaborator

The RemoveDeadFuncsPass returns this error, which was hidden inside a private module.

Adds missing docs to the struct, and converts the tuple variant into a regular struct.

@aborgna-q aborgna-q requested a review from a team as a code owner January 20, 2025 14:40
@aborgna-q aborgna-q requested a review from doug-q January 20, 2025 14:40
@aborgna-q aborgna-q force-pushed the ab/export-dead-fn-pass-error branch from 9263116 to 09bd748 Compare January 20, 2025 14:40
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.55%. Comparing base (e26a31f) to head (09bd748).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-passes/src/dead_funcs.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1883   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         195      195           
  Lines       35584    35584           
  Branches    32397    32397           
=======================================
  Hits        30800    30800           
  Misses       3012     3012           
  Partials     1772     1772           
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 85.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aborgna-q aborgna-q added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 012f2d5 Jan 20, 2025
22 of 23 checks passed
@aborgna-q aborgna-q deleted the ab/export-dead-fn-pass-error branch January 20, 2025 15:03
@hugrbot hugrbot mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants