-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: determine correct bounds of custom types #1888
Conversation
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
==========================================
+ Coverage 86.52% 86.54% +0.01%
==========================================
Files 194 195 +1
Lines 35250 35591 +341
Branches 32063 32404 +341
==========================================
+ Hits 30501 30803 +302
- Misses 2973 3014 +41
+ Partials 1776 1774 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that the test in https://github.com/CQCL/hugr/tree/doug/bounds-bug now does not panic. LGTM.
Import now determines the bound of the custom type correctly.
Fixes #1876.