-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add module root node in Hugr::new #2
Conversation
69e90d7
to
7ced3f2
Compare
I was thinking the same idea, so this looks good to me. Not sure why CI is failing - IIUC the same "errors" show up as warnings when I build branch main. |
The CI is pretty pedantic rn. Lines 4 to 6 in 067e4c5
Edit: The error was already happening in main, but Github Actions was down when that change was pushed. I put a fix for the CI error in #3. |
I made roots optional to allow for partial hugrs meant for rewriting. I'm not yet up to date with the current definition for that. |
Replacements are a forest of nodes. Whilst they could all be stored in a single HUGR I'm not sure how much sense that makes, they could just be a list (there is a ParentsMap as well, right). |
7ced3f2
to
53b1a23
Compare
Wait for #4 before merging this. |
e9eeafb
to
0508cc0
Compare
HUGR should have one root node always - might as well create this with
new