Use a 64-bit USize as the sole integer type in the core
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
reviewed
Aug 9, 2023
src/types/simple.rs
Outdated
| #[inline] | ||
| pub const fn int<const N: HugrIntWidthStore>() -> Self { | ||
| Self::Hashable(HashableType::Int(N)) | ||
| pub const fn int() -> Self { |
There was a problem hiding this comment.
probably worth renaming this method at this point
src/types/simple.rs
Outdated
| } | ||
|
|
||
| /// Returns a new 64-bit integer type. | ||
| #[inline] | ||
| pub const fn i64() -> Self { | ||
| Self::int::<64>() | ||
| Self::int() | ||
| } | ||
|
|
||
| /// Returns a new 1-bit integer type. | ||
| #[inline] | ||
| pub const fn bit() -> Self { |
There was a problem hiding this comment.
remove this method and use int() wherever this is used I think
src/types/simple.rs
Outdated
| f.write_char('I')?; | ||
| f.write_str(&i.to_string()) | ||
| } | ||
| HashableType::USize => f.write_str("I64"), |
There was a problem hiding this comment.
Suggested change
| HashableType::USize => f.write_str("I64"), | |
| HashableType::USize => f.write_str("USize"), |
Comment on lines
-208
to
-221
| fn check_int_fits_in_width( | ||
| value: HugrIntValueStore, | ||
| width: HugrIntWidthStore, | ||
| ) -> Result<(), ConstIntError> { | ||
| if width > HUGR_MAX_INT_WIDTH { | ||
| return Err(ConstIntError::IntWidthTooLarge(width)); | ||
| } | ||
|
|
||
| if VALID_WIDTHS.contains(&width) { | ||
| let max_value = if width == HUGR_MAX_INT_WIDTH { | ||
| HugrIntValueStore::MAX | ||
| } else { | ||
| HugrIntValueStore::pow(2, width as u32) - 1 | ||
| }; |
There was a problem hiding this comment.
should this code go in the int type resource or is some version already there?
There was a problem hiding this comment.
I'll add a test in int_types.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356 .