-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a python package #885
Conversation
Uh, the "approve required checks if they are skipped" doesn't quite work. If we modify files that should be checked and also files to ignore, we end up running both workflows -.- The github docs are not really helpful: I think the best option is to just use https://github.com/dorny/paths-filter. It seems to be a widely used alternative. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
============================================
+ Coverage 85.62% 100.00% +14.37%
============================================
Files 78 1 -77
Lines 14397 2 -14395
Branches 14397 0 -14397
============================================
- Hits 12327 2 -12325
+ Misses 1436 0 -1436
+ Partials 634 0 -634 ☔ View full report in Codecov by Sentry. |
nvm, we can't skip required tests... |
01794b4
to
45b3807
Compare
it doesn't seem to work, the filter always returs `true` if we add something like - '!**/*.md'
Adds all the boilerplate for a
quantinuum-hugr
python package.This includes conditional CI checks (dependant on the changed files), and other metadata.
What's missing is a
release-please
configuration to generate python changelogs.release-plz
should already be configured to only include changes that modify the rust project.This is the foundation required for #486 and CQCL/guppylang#173, and it should make adding another package for #866 quite easy.