Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow non-references in the wrappers #105

Merged
merged 6 commits into from
Sep 5, 2023
Merged

feat: allow non-references in the wrappers #105

merged 6 commits into from
Sep 5, 2023

Conversation

aborgna-q
Copy link
Collaborator

Follow-up for #104.

Instead of requiring &G in the graph filters we just use G: Clone, so other things like G: AsRef<PortGraph> can be used as base.

@aborgna-q aborgna-q requested a review from lmondada August 22, 2023 16:40
Base automatically changed from fix/convex-copy-req to main August 22, 2023 18:00
lmondada
lmondada approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@lmondada lmondada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aborgna-q aborgna-q added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 0ca7058 Sep 5, 2023
@aborgna-q aborgna-q deleted the feat/non-ref-wrappers branch September 5, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmondada lmondada lmondada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aborgna-q @lmondada