Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #179

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

PabloAndresCQ
Copy link
Collaborator

Long overdue improvement of installation experience.

I'd like to make a release once this is merged (so that installation from pypi pulls cuquantum-python), so I've bumped the version.

@PabloAndresCQ
Copy link
Collaborator Author

PabloAndresCQ commented Dec 10, 2024

The build test without GPU in CI is failing due to me including cuquantum-python in the dependencies, which fails when cuda-toolkit is not available. However, it works fine in the CI with GPU.

@jake-arkinstall I suggest we kill the CI checks that build pytket-cutensornet on non-GPU CI. Agreed? We'd need to do the lint check in the nix CI (I believe it's not done atm?)

@jake-arkinstall
Copy link
Collaborator

Yes, having it all run in a cuda environment makes sense. I'll take a look at linting.

@PabloAndresCQ
Copy link
Collaborator Author

Actually, now that I think about it, the linting passes can be run on a machine without cuda (I used to do that when I developed on my work laptop), so the linter can stay in the standard CI. Looks like the error has nothing to do with the builder.

I'll update CI myself and mark it as ready for review when I'm done (I'll probably do it tomorrow). Thanks Jake!

@PabloAndresCQ PabloAndresCQ marked this pull request as ready for review December 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants