Remove pytket-quantinuum dependency. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
requested changes
Jan 25, 2024
qartik
reviewed
Jan 25, 2024
qartik
previously approved these changes
Jan 25, 2024
There was a problem hiding this comment.
LGTM. I'd wait for @neal-erickson's review before merging this. Also, left a minor comment.
neal-erickson
previously approved these changes
Jan 25, 2024
pytket/phir/rebasing/rebaser.py
Outdated
| api_handler=qapi_offline, # type: ignore [arg-type] | ||
| machine = QTM_MACHINES_MAP.get(qtm_machine) | ||
| gateset = ( | ||
| {OpType.Rz, OpType.PhasedX, OpType.ZZPhase} |
There was a problem hiding this comment.
This is roughly equivalent to the Quantinuum gateset, do we want to rebase to that in the case of no machine - seems like it might reduce the flexibility of allowing this to be run without any Quantinuum specificity.
There was a problem hiding this comment.
I changed the code to use QTM_DEFAULT_GATESET explicitly. I don't think this reduces flexibility, as one can specify a machine with another gateset if desired.
qartik
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the
tket_optimization_levelargument topytket_to_phir(). Add agatesetfield to theMachineclass and populate theQtmMachineinstances with the current supported gatesets. Apply a standard rebase pass after decomposing boxes (i.e. optimization level 0).Create a dataclass for machine timing data to get around ruff's (quite reasonable) complaint that there were too many arguments to
Machine.__init__().