Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent parallel blocks in 1-qubit circuits #109

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Prevent parallel blocks in 1-qubit circuits #109

merged 6 commits into from
Jan 25, 2024

Conversation

Asa-Kosto-QTM
Copy link
Collaborator

@Asa-Kosto-QTM Asa-Kosto-QTM commented Jan 25, 2024 •
edited
Loading

fixed issue causing parallel blocks in 1qubit circuit
added test
tests in test_api were failing when run in a certain order, moved them to pass, raised issue 108

qartik
qartik requested changes Jan 25, 2024
View reviewed changes
pytket/phir/api.py Outdated Show resolved Hide resolved
tests/data/qasm/issue106_1qubit.qasm Outdated Show resolved Hide resolved
tests/test_parallelization.py Outdated Show resolved Hide resolved
pytket/phir/phirgen_parallel.py Outdated Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
@qartik qartik linked an issue Jan 25, 2024 that may be closed by this pull request
Single-qubit circuit has parallel blocks and returns different results for different TKET optimization levels #106
Closed
neal-erickson
neal-erickson previously approved these changes Jan 25, 2024
View reviewed changes
qartik
qartik previously approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I reduced duplication in the new test case added.

@qartik qartik changed the title Fixing Issue 106 (parallel blocks in 1Qubit circuit) Prevent parallel blocks in 1-qubit circuits Jan 25, 2024
@qartik qartik merged commit 13a18e3 into main Jan 25, 2024
6 checks passed
@qartik qartik deleted the 106-parallel-1qubit-circuit branch January 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qartik qartik qartik approved these changes

@neal-erickson neal-erickson Awaiting requested review from neal-erickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single-qubit circuit has parallel blocks and returns different results for different TKET optimization levels
3 participants
@Asa-Kosto-QTM @neal-erickson @qartik