Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 133 bugfix for nested bitwise ops #135

Merged
merged 4 commits into from
Feb 21, 2024
Merged

issue 133 bugfix for nested bitwise ops #135

merged 4 commits into from
Feb 21, 2024

Conversation

Asa-Kosto-QTM
Copy link
Collaborator

@Asa-Kosto-QTM Asa-Kosto-QTM commented Feb 20, 2024 •
edited
Loading

recursive call in classical op is now bitwise
tests still pass after removing type error at lines 150,151 in phirgen.py

Fixes #133

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

qartik
qartik reviewed Feb 20, 2024
View reviewed changes
pytket/phir/phirgen.py Outdated Show resolved Hide resolved
qartik
qartik reviewed Feb 20, 2024
View reviewed changes
pytket/phir/phirgen.py Outdated Show resolved Hide resolved
Asa-Kosto-QTM and others added 3 commits February 20, 2024 15:43
@Asa-Kosto-QTM @qartik
Update pytket/phir/phirgen.py
8dead83 
Co-authored-by: Kartik Singhal <kartik.singhal@quantinuum.com>
@Asa-Kosto-QTM @qartik
Update pytket/phir/phirgen.py
137625b 
Co-authored-by: Kartik Singhal <kartik.singhal@quantinuum.com>
@qartik
fix(phirgen): handle bitwise logical operations correctly
5d3bbf9
@qartik qartik requested a review from cqc-alec February 21, 2024 01:00
@Asa-Kosto-QTM Asa-Kosto-QTM merged commit 2604e8e into main Feb 21, 2024
6 checks passed
@Asa-Kosto-QTM Asa-Kosto-QTM deleted the classical-exp-bug branch February 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

@qartik qartik qartik approved these changes

@neal-erickson neal-erickson Awaiting requested review from neal-erickson

@peter-campora peter-campora Awaiting requested review from peter-campora

@dlucchetti dlucchetti Awaiting requested review from dlucchetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Classical operations composed of several binary operations incorrectly converted to PHIR
3 participants
@Asa-Kosto-QTM @cqc-alec @qartik