feat(phirgen): add support for Sleep/Idle mop #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asa-Kosto-QTM
previously approved these changes
Mar 4, 2024
cqc-alec
reviewed
Mar 5, 2024
cqc-alec
previously approved these changes
Mar 5, 2024
Asa-Kosto-QTM
previously approved these changes
Mar 5, 2024
| @@ -0,0 +1,17 @@ | |||
| OPENQASM 2.0; | |||
There was a problem hiding this comment.
Good minimal test. I'd like to see an additional program use multiple sleeps on different qubits just as an extra sanity check in the test suite.
peter-campora
previously approved these changes
Mar 5, 2024
qciaran
reviewed
Mar 5, 2024
qartik
dismissed stale reviews from qciaran, peter-campora, and Asa-Kosto-QTM
via
c819880
cqc-alec
reviewed
Mar 6, 2024
handle all op.data cases as suggested by Alec
cqc-alec
approved these changes
Mar 6, 2024
Asa-Kosto-QTM
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for QASM's
sleepoperation that gets converted by pytket into a barrier withop.datacarrying the sleep information. We convert it into the existing PHIR"Idle""mop".Also update several dependencies.
Type of change
Checklist: