Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do nothing on Init gate instead of warning #166

Merged
merged 2 commits into from
Apr 11, 2024
Merged

do nothing on Init gate instead of warning #166

merged 2 commits into from
Apr 11, 2024

Conversation

Asa-Kosto-QTM
Copy link
Collaborator

@Asa-Kosto-QTM Asa-Kosto-QTM commented Apr 10, 2024 •
edited
Loading

Description

Do not display a "No transport duration assigned to gate type 'Init'" warning, it is unnecessary.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog with any user-facing changes

qartik
qartik reviewed Apr 11, 2024
View reviewed changes
pytket/phir/phirgen_parallel.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth removing the code duplication in the two matches, considering abstracting the match to a function?

qartik
qartik approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Asa-Kosto-QTM Asa-Kosto-QTM merged commit 8438142 into main Apr 11, 2024
6 checks passed
@Asa-Kosto-QTM Asa-Kosto-QTM deleted the init-gate-duration-bug branch April 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neal-erickson neal-erickson neal-erickson approved these changes

@qartik qartik qartik approved these changes

@qciaran qciaran Awaiting requested review from qciaran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asa-Kosto-QTM @neal-erickson @qartik