Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maximum bit width for classical operations according to pytket support #190

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

cqc-alec
Copy link
Collaborator

Description

See also CQCL/tket#1456 .

Fixes #165 .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog with any user-facing changes

@cqc-alec cqc-alec requested a review from qartik June 18, 2024 10:47
Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qartik
Copy link
Member

qartik commented Jun 18, 2024

One question, do we still require a maxwidth parameter for pytket-phir as mentioned in #165?

To me it seems it's being fully handled in pytket and pulled in here with your change in this PR. So perhaps not.

@cqc-alec
Copy link
Collaborator Author

One question, do we still require a maxwidth parameter for pytket-phir as mentioned in #165?

To me it seems it's being fully handled in pytket and pulled in here with your change in this PR. So perhaps not.

I agree, we probably don't need that parameter now.

@qartik
Copy link
Member

qartik commented Jun 18, 2024

Feel free to merge. I can make a new release once CQCL/tket#1456 is merged and released so we can do integration testing.

@cqc-alec
Copy link
Collaborator Author

Thanks, I think it needs one more approval before I can merge it.

I would actually like this to be released before the change in CQCL/tket#1456 is released, if at all possible. This is so that pytket-quantinuum can depend on the new release of pytket-phir, and won't break when the new release of pytket is made.

@qartik
Copy link
Member

qartik commented Jun 18, 2024

In that case, let me take it from here and make a new release.

@qartik qartik merged commit a381df6 into main Jun 18, 2024
6 checks passed
@qartik qartik deleted the ae/64bit branch June 18, 2024 13:03
@cqc-alec
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UINTMAX is hard-coded as 2^32 - 1
2 participants