fix: Abstract WORDSIZE to specify maxwidth on qasm conversion #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
commented
Jul 15, 2024
cqc-alec
previously approved these changes
Jul 15, 2024
dlucchetti
previously approved these changes
Jul 15, 2024
qartik
commented
Jul 15, 2024
| @@ -31,7 +31,7 @@ dependencies = [ | |||
|
|
|||
| [project.optional-dependencies] | |||
| docs = ["sphinx", "pydata_sphinx_theme"] | |||
| phirc = ["projectq", "quantum-pecos>=0.5.0.dev10"] | |||
| phirc = ["projectq", "quantum-pecos>=0.6.0.dev2"] | |||
There was a problem hiding this comment.
64-bit support added in https://github.com/PECOS-packages/PECOS/releases/tag/v0.6.0.dev2
qartik
commented
Jul 15, 2024
| @@ -544,7 +556,7 @@ def get_decls(qbits: set["Qubit"], cbits: set[tkBit]) -> list[dict[str, str | in | |||
| decls += [ | |||
| { | |||
| "data": "cvar_define", | |||
| "data_type": "u32", | |||
| "data_type": f"i{WORDSIZE}", | |||
There was a problem hiding this comment.
Changing to i64 as the default as per the spec. Tested with previous version of pytket to check that i32 works as well.
cqc-alec
approved these changes
Jul 16, 2024
dlucchetti
approved these changes
Jul 16, 2024
qartik
deleted the
203-incorrect-bitwidth-for-qasm-input-with-pytket-1300
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes pytket-phir compatible with pytket version 1.30.0 while maintaining backward compatibility.
Fixes: #203
Type of change
Checklist