Add support for CopyBits op
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
commented
Dec 14, 2023
cqc-alec
requested changes
Dec 14, 2023
|
The test breakage seems unrelated to this set of changes, @Asa-Kosto-QTM is looking into that. |
neal-erickson
previously approved these changes
Dec 14, 2023
cqc-alec
previously approved these changes
Dec 14, 2023
Asa-Kosto-QTM
dismissed stale reviews from cqc-alec and neal-erickson
via
70ee961
qartik
commented
Dec 14, 2023
pytket/phir/phirgen_parallel.py
Outdated
| # sort to ensure deterministic order of qbuits/cbits in output | ||
| # lowest -> highest | ||
| fmt_measure["args"].sort() | ||
| fmt_measure["returns"].sort() |
There was a problem hiding this comment.
@Asa-Kosto-QTM is this always going to be correct?
There was a problem hiding this comment.
I am confident that it will. The args/bits are always in this format ['q' or 'c', number] and it sorts by the number. As long as that format doesn't change it should work
There was a problem hiding this comment.
Thanks, removing this commit from this PR just to keep things separated.
|
I will wait to merge this until the tests are fixed in another PR. |
Asa-Kosto-QTM
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61