Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZ/R1XY order swapping #82

Merged
merged 9 commits into from
Jan 10, 2024
Merged

RZ/R1XY order swapping #82

merged 9 commits into from
Jan 10, 2024

Conversation

Asa-Kosto-QTM
Copy link
Collaborator

fixing a bug that showed up in the rxrz.qasm circuit where the relative ordering of subcommands was not preserved.

Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, looking good otherwise.

pytket/phir/phirgen_parallel.py Outdated Show resolved Hide resolved
tests/test_parallel_subcommand_relative_ordering.py Outdated Show resolved Hide resolved
tests/test_parallel_subcommand_relative_ordering.py Outdated Show resolved Hide resolved
Asa-Kosto-QTM and others added 2 commits January 9, 2024 16:52
Co-authored-by: Kartik Singhal <kartik.singhal@quantinuum.com>
Co-authored-by: Kartik Singhal <kartik.singhal@quantinuum.com>
qciaran
qciaran previously approved these changes Jan 9, 2024
Copy link
Collaborator

@qciaran qciaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM This solves the issue I had on my side.

Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to move the test into existing test file.

pytket/phir/cli.py Outdated Show resolved Hide resolved
@Asa-Kosto-QTM Asa-Kosto-QTM merged commit 5ed2c4f into main Jan 10, 2024
2 checks passed
@Asa-Kosto-QTM Asa-Kosto-QTM deleted the rxrx-order-swapping branch January 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants