-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RZ/R1XY order swapping #82
Conversation
…mand ordering and added unit test with offending circuit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, looking good otherwise.
Co-authored-by: Kartik Singhal <kartik.singhal@quantinuum.com>
Co-authored-by: Kartik Singhal <kartik.singhal@quantinuum.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM This solves the issue I had on my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to move the test into existing test file.
fixing a bug that showed up in the rxrz.qasm circuit where the relative ordering of subcommands was not preserved.