fix(phirgen): pattern match on all possible regwise/bitwise ops #94
Conversation
qartik
changed the title
|
Marking as ready since the translation is correct. Currently PECOS doesn't support |
qartik
force-pushed
the
93-missing-support-for-regwiseopand-and-regwiseopor
branch
from
0489eca
to
e4752f8
Compare
| @@ -118,23 +125,36 @@ def regwise_cop(exp: LogicExp) -> JsonDict: | |||
| cop = "<=" | |||
| case RegWiseOp.GEQ: | |||
| cop = ">=" | |||
| case RegWiseOp.NOT: | |||
| cop = "~" | |||
| case other: | |||
There was a problem hiding this comment.
Why drop this error handler?
There was a problem hiding this comment.
If we are matching all possibilities, the other case is unreachable.
There was a problem hiding this comment.
If we are matching all possibilities, the
othercase is unreachable.
Indeed, but is there any guarantee that we are? What if pytket were to add another one in the future (or the function were passed an invalid argument)? Wouldn't it be safer to keep the check?
There was a problem hiding this comment.
Thanks for making me think extra hard about this. Found a solution, just pushed.
qartik
force-pushed
the
93-missing-support-for-regwiseopand-and-regwiseopor
branch
from
e4752f8
to
facfb20
Compare
qartik
deleted the
93-missing-support-for-regwiseopand-and-regwiseopor
branch
I need to confirm whether PECOS/PHIR supports the
POWoperation as the spec doesn't list it.