add seed list feature (#197)

* add seed list feature * remove list, add auto inc * requsted changes ii, make auto inc default, remove parameter * remove testcases, clean up changes not needed
CQCL · Nov 8, 2023 · 45b42d3 · 45b42d3
1 parent c04a291
commit 45b42d3
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -9,6 +9,8 @@ unreleased
 * Update qiskit-ibm-runtime version to 0.13.0.
 * Update qiskit-aer version to 0.13.0.
 * Introduce dependency on qiskit-algorithms.
+* Seed given to ``process_circuits()`` will be automatically incremented
+  for the different circuit batches submitted.
 
 0.45.0 (October 2023)
 ---------------------

diff --git a/pytket/extensions/qiskit/backends/aer.py b/pytket/extensions/qiskit/backends/aer.py
@@ -239,6 +239,10 @@ def process_circuits(
         valid_check: bool = True,
         **kwargs: KwargTypes,
     ) -> List[ResultHandle]:
+        """
+        See :py:meth:`pytket.backends.Backend.process_circuits`.
+        Supported kwargs: `seed`, `postprocess`.
+        """
         circuits = list(circuits)
         n_shots_list = Backend._get_n_shots_as_list(
             n_shots,
@@ -258,6 +262,7 @@ def process_circuits(
             circuits = noisy_circuits
 
         handle_list: List[Optional[ResultHandle]] = [None] * len(circuits)
+        seed = kwargs.get("seed")
         circuit_batches, batch_order = _batch_circuits(circuits, n_shots_list)
 
         replace_implicit_swaps = self.supports_state or self.supports_unitary
@@ -275,14 +280,15 @@ def process_circuits(
             if self._needs_transpile:
                 qcs = transpile(qcs, self._qiskit_backend)
 
-            seed = cast(Optional[int], kwargs.get("seed"))
             job = self._qiskit_backend.run(
                 qcs,
                 shots=n_shots,
                 memory=self._memory,
                 seed_simulator=seed,
                 noise_model=self._noise_model,
             )
+            if type(seed) is int:
+                seed += 1
             jobid = job.job_id()
             for i, ind in enumerate(indices):
                 handle = ResultHandle(jobid, i)

diff --git a/pytket/extensions/qiskit/backends/ibm_utils.py b/pytket/extensions/qiskit/backends/ibm_utils.py
@@ -39,7 +39,8 @@
 
 
 def _batch_circuits(
-    circuits: Sequence["Circuit"], n_shots: Sequence[Optional[int]]
+    circuits: Sequence["Circuit"],
+    n_shots: Sequence[Optional[int]],
 ) -> Tuple[List[Tuple[Optional[int], List["Circuit"]]], List[List[int]]]:
     """
     Groups circuits into sets of circuits with the same number of shots.

diff --git a/pytket/extensions/qiskit/backends/ibmq_emulator.py b/pytket/extensions/qiskit/backends/ibmq_emulator.py
@@ -139,6 +139,7 @@ def process_circuits(
         )
 
         handle_list: List[Optional[ResultHandle]] = [None] * len(circuits)
+        seed = kwargs.get("seed")
         circuit_batches, batch_order = _batch_circuits(circuits, n_shots_list)
 
         batch_id = 0  # identify batches for debug purposes only
@@ -173,7 +174,9 @@ def process_circuits(
                 options.resilience_level = 0
                 options.execution.shots = n_shots
                 options.simulator.noise_model = self._noise_model
-                options.seed_simulator = kwargs.get("seed")
+                options.seed_simulator = seed
+                if type(seed) is int:
+                    seed += 1
                 sampler = Sampler(session=self._session, options=options)
                 job = sampler.run(circuits=qcs)
                 job_id = job.job_id()