Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol conversion into qiskit #377

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Fix symbol conversion into qiskit #377

merged 5 commits into from
Aug 16, 2024

Conversation

cqc-alec
Copy link
Collaborator

Description

Fix the conversion of symbols from pytket circuits to qiskit so that round-trip equality checks pass.

This needs qiskit >= 1.2.0 to work, so bump the minimum qiskit version.

Related issues

Fixes #376 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec marked this pull request as ready for review August 16, 2024 10:39
@cqc-alec cqc-alec requested a review from cqc-melf as a code owner August 16, 2024 10:39
Copy link
Collaborator

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump up the pytket version, too.
Do you want to do that in this PR?

@cqc-alec
Copy link
Collaborator Author

We should bump up the pytket version, too. Do you want to do that in this PR?

I was thinking to do that in a separate PR.

@cqc-alec cqc-alec merged commit 480227d into main Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: test_parameter_equality()
2 participants