Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melf/add ruff 2024 #397

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Melf/add ruff 2024 #397

merged 12 commits into from
Oct 25, 2024

Conversation

cqc-melf
Copy link
Collaborator

@cqc-melf cqc-melf commented Oct 4, 2024

Description

Please summarise the changes.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-melf cqc-melf marked this pull request as ready for review October 24, 2024 16:15
@cqc-melf cqc-melf requested a review from cqc-alec October 24, 2024 16:15
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe we can revisit the "noqa" lines later, but a big improvement.

@@ -549,7 +551,7 @@ def process_circuits(
handle_list[ind] = ResultHandle(
job_id, i, qcs[i].count_ops()["measure"], ppcirc_strs[i]
)
batch_id += 1
batch_id += 1 # noqa: SIM113
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use an enumerate() here.

@cqc-melf cqc-melf merged commit 4af1cbf into main Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants