refactor: minor improvement to qiskit_to_tk conversion.
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMacCQ
commented
Oct 23, 2024
| @@ -524,7 +534,7 @@ def add_qiskit_data( | |||
| q_ctrl_box = _get_qcontrol_box(c_gate=instr, params=params) | |||
| self.tkc.add_qcontrolbox(q_ctrl_box, qubits) | |||
|
|
|||
| elif isinstance(instr, (Initialize, StatePreparation)): | |||
| elif optype == OpType.StatePreparationBox: | |||
There was a problem hiding this comment.
Seems more correct to match the optype as both of the qiskit instructions are mapped to a StatePreparationBox instance.
There was a problem hiding this comment.
In fact we could probably rewrite CircuitBuilder.add_qiskit_data to just check the optype and not look at the qiskit Instruction. This would be nicer as the whole method would just be matching on the values of the optype variable. Its just the handling of UnitaryGate and PauliEvolutionGate that are preventing this at the moment.
cqc-melf
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just pulled out the circbox building in
qiskit_to_tkinto a separate function. This reduces indentation and the number of lines in theCircuitBuilder.add_qiskit_datamethod.Related issues
#313
Checklist