Specify what result types we expect in our Qiskit result conversion functions #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not included in any of the existing calls to this function, and the last time it seems to have been used is by IBMQBackend before the Qiskit API changed (since now IBMQBackend.get_results() handles its own result conversion).
And when we call those conversion methods from _AerBaseBackend.get_results(), pass what we know about what the backend is expected to support. This should mean that if we run anything on AerStateBackend or AerUnitaryBackend, we don't get counts passed back even if the Qiskit result included them.
isobelhooper
force-pushed
the
bugfix/specify-what-we-expect-in-qiskit-result-conversion
branch
from
c11e63c to
6f320e2
Compare
cqc-melf
approved these changes
Oct 24, 2024
isobelhooper
deleted the
bugfix/specify-what-we-expect-in-qiskit-result-conversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds parameters to
qiskit_result_to_backendresult/qiskit_experimentresult_to_backendresultto specify which type of results we expect to have back.Previously, circuits with classical bits submitted to AerStateBackend would have a
countsfield in their returned result, because Qiskit reads from the classical register memory. Now we don't set that, because we don't expect counts to be returned from AerStateBackend so we ignore that field.Also, we weren't ever passing in anything to
ppcircinqiskit_experimentresult_to_backendresult, so after discussion with @cqc-melf and @cqc-alec that's been removed as part of this PR.Related issues
Please mention any github issues addressed by this PR.
Checklist