Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert warning related to implcit swaps #418

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Revert warning related to implcit swaps #418

merged 7 commits into from
Nov 20, 2024

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Nov 20, 2024 •
edited
Loading

Description

reverts #412

See explanation here -> #411 (comment)

Drive by: Clarify how the default pass works in the docs for AerBackend when no NoiseModel is used.

Related issues

#411

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@CalMacCQ CalMacCQ requested a review from cqc-melf as a code owner November 20, 2024 15:47
cqc-melf
cqc-melf previously approved these changes Nov 20, 2024
View reviewed changes
@CalMacCQ CalMacCQ requested a review from cqc-alec November 20, 2024 15:58
@CalMacCQ CalMacCQ merged commit 7befd51 into main Nov 20, 2024
6 checks passed
@CalMacCQ CalMacCQ deleted the fix/revert_impl_warning branch November 26, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

@cqc-melf cqc-melf cqc-melf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalMacCQ @cqc-alec @cqc-melf