fix: Add missing OpTypes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Apr 8, 2024
src/opbox.rs
Outdated
| pauli_gadgets: Vec<(Vec<String>, String)>, | ||
| /// Synthesis strategy. See [`PauliSynthStrat`]. | ||
| #[serde(default)] | ||
| synthesis_strategy: PauliSynthStrat, |
There was a problem hiding this comment.
Can we make the names match those used in TKET serialization ( https://github.com/CQCL/tket/blob/a2f6fab8a57da8787dfae94764b7c3a8e5779024/schemas/circuit_v1.json#L832 )?
There was a problem hiding this comment.
I did a full pass on the schema to ensure our definition is up-to-date.
Apparently some of the already-present box definitions where missing or incorrect, so I also fixed them.
There was a problem hiding this comment.
Unfortunately #36 won't be able to catch mismatching attributes.
To validate that we'd need to add tests that construct each possible pytket optype and check it against the rust code 🤔
I may add a low-priority issue for that.
src/optype.rs
Outdated
| @@ -207,6 +213,12 @@ pub enum OpType { | |||
| /// \end{array} \right] \f$ | |||
| CSXdg, | |||
|
|
|||
| /// Controlled \ref OpType::S gate | |||
There was a problem hiding this comment.
Use rust style for cross-references rather than doxygen style. (Several more examples of this below.)
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
## 🤖 New release * `tket-json-rs`: 0.3.1 -> 0.4.0 (⚠️ API breaking changes) ###⚠️ `tket-json-rs` breaking changes ``` --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/enum_missing.ron Failed in: enum tket_json_rs::circuit_json::OpBox, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:67 enum tket_json_rs::circuit_json::ToffoliBoxSynthStrat, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:302 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/struct_missing.ron Failed in: struct tket_json_rs::circuit_json::BoxID, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:58 struct tket_json_rs::circuit_json::PauliStabiliser, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:51 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.4.0 (2024-04-08) ### Bug Fixes - Add missing OpTypes ([#37](#37)) ### Miscellaneous Tasks - [**breaking**] Update pyo3 to 0.21 ([#33](#33)) ### Refactor - Move `OpBox` to a new module ([#35](#35)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing optypes listed in #36.
Fixes #30.