reject incomplete registers in pytket to qasm conv #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
previously approved these changes
Nov 5, 2024
pytket/pytket/qasm/qasm.py
Outdated
Comment on lines
1146
to
1149
| for b in set([b.reg_name for b in circ.bits]): | ||
| if b not in set_circ_register: | ||
| raise QASMUnsupportedError( | ||
| f"Circuit contains a invalid classical register {b}." |
There was a problem hiding this comment.
Suggested change
| for b in set([b.reg_name for b in circ.bits]): | |
| if b not in set_circ_register: | |
| raise QASMUnsupportedError( | |
| f"Circuit contains a invalid classical register {b}." | |
| for b in circ.bits: | |
| if b.reg_name not in set_circ_register: | |
| raise QASMUnsupportedError( | |
| f"Circuit contains a invalid classical register {b.reg_name}." |
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
cqc-alec
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #1457
Related issues
Please mention any github issues addressed by this PR.
Checklist