perf: Avoid rehashing in index_map #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IndexMap data structure is an unordered_map which means that if the hash table is too small it can result in having to rehash all members of the table as seen in #1696 . This commit attempts to reserve an exact size of hash table up front such that rehashing is unlikely as an additional optimization for large circuits.
|
Closing in favor of: #1699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The IndexMap data structure is an unordered_map which means that if the hash table is too small it can result in having to rehash all members of the table as seen in #1696 .
This commit attempts to reserve an exact size of hash table up front such that rehashing is unlikely as an additional optimization for large circuits.
Related issues
#1696 <- original issue
#1697 <- reduces the number of calls to index_map
Checklist