Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greedy_depth_reduce produces invalid circuits #253

Closed
aborgna-q opened this issue Nov 21, 2023 · 2 comments · Fixed by #264 or #435
Closed

greedy_depth_reduce produces invalid circuits #253

aborgna-q opened this issue Nov 21, 2023 · 2 comments · Fixed by #264 or #435
Labels
bug Something isn't working

Comments

@aborgna-q
Copy link
Collaborator

The branch test/depth-reduce contains an example where the optimisation pass returns a circuit with a different unitary from the original.

Checkout the branch and run with

$ just pydevelop
$ python invalid.py

Here are two circuits where this fails:
3b9bab70-d668-11ea-a4be-38f9d36dfbf2-pre.json
01e360c0-d669-11ea-8a28-38f9d36dfbf2-pre.json
@aborgna-q aborgna-q added bug Something isn't working P-high labels Nov 21, 2023
@ss2165
Copy link
Member

ss2165 commented Dec 8, 2023 •
edited
Loading

minimal example found with python hypothesis testing:
Circuit(3).H(2).CX(2, 1).CX(0, 2).CX(0, 1)
gets reduced to just Circuit(3).H(2)

@ss2165
Copy link
Member

ss2165 commented Dec 8, 2023

Included as a failing test in branch fix/253

@ss2165 ss2165 mentioned this issue Dec 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 15, 2023
@ss2165
fix: induced cycles in depth optimisation (#264)
68c9ff2 
Closes #253
@hugrbot hugrbot mentioned this issue May 24, 2024
Closed
@hugrbot hugrbot mentioned this issue Jun 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2024
@hugrbot @aborgna-q
chore(main): release tket2-py 0.1.0a1 (#435)
ea48d16 
🤖 I have created a release *beep* *boop*
---


## 0.1.0 (2024-06-28)


### ⚠ BREAKING CHANGES

* require `hugr-0.5.0`
* Replaced `tket2.circuit.OpConvertError` with
`tket2.circuit.TK1ConvertError` in the python lib.
* Moved `tket2::json` to `tket2::serialize::pytket`
* Replaced the `Circuit` trait with a wrapper struct.
* This is a breaking change to the compiled rewriter serialisation
format.

### Features

* Add a "progress timeout" to badger
([#259](#259))
([556cf64](556cf64))
* Add missing typing hints
([#352](#352))
([4990613](4990613))
* bindings for circuit cost and hash
([#252](#252))
([85ce5f9](85ce5f9))
* drop pyo3 core dep ([#355](#355))
([9f7d415](9f7d415))
* EccRewriter bindings
([#251](#251))
([97e2e0a](97e2e0a))
* guppy → pytket conversion
([#407](#407))
([8c5a487](8c5a487))
* Implement `PyErr` conversion locally in `tket2-py`
([#258](#258))
([3e1a68d](3e1a68d))
* init tket2-hseries ([#368](#368))
([61e7535](61e7535))
* pauli propagation use case example
([#333](#333))
([f46973c](f46973c))
* **py:** Allow using `Tk2Op`s in the builder
([#436](#436))
([aed8651](aed8651))
* Support any ops in portmatching
([#293](#293))
([6b05a05](6b05a05))
* **tket2-py:** Bind the `lower_to_pytket` pass in python
([#439](#439))
([8208324](8208324))
* Use tket1 and tket2 circuits interchangeably everywhere
([#243](#243))
([eac7acf](eac7acf))
* Utilities for loading compiled guppy circuits
([#393](#393))
([028779a](028779a))


### Bug Fixes

* failed importlib import
([#254](#254))
([b077660](b077660))
* induced cycles in depth optimisation
([#264](#264))
([68c9ff2](68c9ff2)),
closes [#253](#253)
* Make native py modules behave like python's
([#212](#212))
([4220038](4220038)),
closes [#209](#209)
* pytest failing to find `tket2` in CI
([#367](#367))
([a9df8e6](a9df8e6))
* **tket2-py:** Replace `with_hugr` helpers with `with_circ`, keeping
the circuit parent. ([#438](#438))
([b77b3cb](b77b3cb))


### Documentation

* Add some example notebooks for the python package.
([#443](#443))
([4ed276c](4ed276c)),
closes [#434](#434)
* Update tket2-py readme
([6c8f18a](6c8f18a))


### Code Refactoring

* Rename `tket2::json` into `tket2::serialize::pytket`
([#392](#392))
([93e611c](93e611c))
* Replace Circuit trait with a struct
([#370](#370))
([ec5dd22](ec5dd22))
* Simplify tket1 conversion errors
([#408](#408))
([b0b8aff](b0b8aff))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustin Borgna <agustin.borgna@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@ss2165 @aborgna-q