Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move rust bindings to tket2._tket2 #351

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

First step towards #350.

Deinterlaces the rust-binded modules from the pure python ones. And puts them in _tket
For now, we still re-export everything directly, I'll add the python wrappers and missing typing info in a following PR.

@aborgna-q aborgna-q requested a review from ss2165 May 21, 2024 16:00
@aborgna-q aborgna-q changed the title refactor!: Move rust bindings to tket2._tket2 refactor: Move rust bindings to tket2._tket2 May 21, 2024
@aborgna-q
Copy link
Collaborator Author

Removing the breaking change flag, since this only affects internal (_*) modules

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (8aff57a) to head (e463cf5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   85.00%   85.33%   +0.32%     
==========================================
  Files          36       36              
  Lines        4554     4554              
  Branches     4293     4293              
==========================================
+ Hits         3871     3886      +15     
+ Misses        504      488      -16     
- Partials      179      180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@aborgna-q aborgna-q added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit a7f3909 May 22, 2024
11 of 12 checks passed
@aborgna-q aborgna-q deleted the ab/pure-python-api branch May 22, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants