Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump devenv.lock #369

Merged
merged 1 commit into from
May 30, 2024
Merged

chore: bump devenv.lock #369

merged 1 commit into from
May 30, 2024

Conversation

doug-q
Copy link
Contributor

@doug-q doug-q commented May 30, 2024

No description provided.

@doug-q doug-q requested a review from ss2165 May 30, 2024 07:53
@doug-q
Copy link
Contributor Author

doug-q commented May 30, 2024

For interest: this includes https://github.com/nix-community/fenix/pull/147, which let's me remove from my devenv.local.nix:

  languages.rust = {
   toolchain.rust-analyzer = let
      channel = if config.languages.rust.channel  == "nightly" then "latest" else config.languages.rust.channel;
      toolchain = (config.lib.getInput {
        name = "fenix";
        url = "github:nix-community/fenix";
        attribute = "languages.rust.version";
        follows = [ "nixpkgs" ];
      }).packages.${pkgs.stdenv.system}.${channel};
    in toolchain.rust-analyzer.overrideAttrs (old:  {
        installPhase = old.installPhase + ''
          patchelf --set-rpath ${toolchain.rustc}/lib $out/bin/rust-analyzer || true
        '';
      });
  };

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (c77f327) to head (0245298).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   85.42%   85.10%   -0.33%     
==========================================
  Files          37       37              
  Lines        4564     4564              
  Branches     4290     4290              
==========================================
- Hits         3899     3884      -15     
- Misses        485      501      +16     
+ Partials      180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check succeeded on my system 👍

@doug-q doug-q added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit bc17af7 May 30, 2024
11 checks passed
@doug-q doug-q deleted the doug/bump-devenv-2024-05-30 branch May 30, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants