-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add script to recompile the ECC sets #514
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 64 64
Lines 6647 6648 +1
Branches 6126 6127 +1
=======================================
+ Hits 5550 5551 +1
Misses 817 817
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a few shell nits. I recommend adding .gitattributes
to test_files/eccs with * -diff
to mark these files as binary
Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
I went with |
test_files/eccs
just recompile-eccs
command / script to regenerate the.rwr
files.Note that the compilation is not deterministic, so we should avoid running it unless needed to avoid bloating the git history.