Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add script to recompile the ECC sets #514

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

  • Moves the loose ECC files into test_files/eccs
  • Adds a just recompile-eccs command / script to regenerate the .rwr files.

Note that the compilation is not deterministic, so we should avoid running it unless needed to avoid bloating the git history.

@aborgna-q aborgna-q added the ci CI / devops label Jul 29, 2024
@aborgna-q aborgna-q requested a review from doug-q July 29, 2024 09:35
@aborgna-q aborgna-q requested a review from a team as a code owner July 29, 2024 09:35
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (54564fc) to head (f9cffc1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          64       64           
  Lines        6647     6648    +1     
  Branches     6126     6127    +1     
=======================================
+ Hits         5550     5551    +1     
  Misses        817      817           
  Partials      280      280           
Flag Coverage Δ
python 96.73% <ø> (ø)
rust 82.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a few shell nits. I recommend adding .gitattributes to test_files/eccs with * -diff to mark these files as binary

scripts/compile-test-eccs.sh Outdated Show resolved Hide resolved
scripts/compile-test-eccs.sh Outdated Show resolved Hide resolved
scripts/compile-test-eccs.sh Outdated Show resolved Hide resolved
scripts/compile-test-eccs.sh Show resolved Hide resolved
aborgna-q and others added 2 commits July 29, 2024 11:05
Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
@aborgna-q
Copy link
Collaborator Author

I went with binary instead of -diff, as it also unsets merge and text

@aborgna-q aborgna-q added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit e272cf7 Jul 29, 2024
16 checks passed
@aborgna-q aborgna-q deleted the ab/regenerate-eccs-sh branch July 29, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI / devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants